Bugfix/2755 IllegalStateException after read timeout#2845
Open
denyskonakhevych wants to merge 9 commits intocodecentric:masterfrom
Open
Bugfix/2755 IllegalStateException after read timeout#2845denyskonakhevych wants to merge 9 commits intocodecentric:masterfrom
denyskonakhevych wants to merge 9 commits intocodecentric:masterfrom
Conversation
Author
|
@SteKoe formatted code in PR |
erikpetzold
reviewed
Oct 30, 2023
Contributor
erikpetzold
left a comment
erikpetzold
left a comment
There was a problem hiding this comment.
Thanks for providing the fix :)
Can you please add tests showing the new code works. Ideally they should succeed with your changes and fail when running against the original code.
| <dependency> | ||
| <groupId>io.projectreactor.netty</groupId> | ||
| <artifactId>reactor-netty-http</artifactId> | ||
| <optional>true</optional> |
Contributor
There was a problem hiding this comment.
I'm not sure how to define the dependency here correctly.
webflux is optional and you only need the reactor-netty-http in webflux case, so this is optional, too.
But when webflux is used, this is now required, right? So the users would need to include this dependency additionally? How do they know this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.